Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tta 63 fix args types #21

Open
wants to merge 6 commits into
base: develop-old
Choose a base branch
from
Open

Conversation

ryancwalsh
Copy link
Contributor

See https://near-foundation.atlassian.net/browse/TTA-63

This PR:

  • deletes getArgsAsObjectUsingBase64Fallback since NEAR Protocol in Rust already populates the args_json field from args_base64 when possible
  • moves type definitions to index.d.ts
  • cleans up ActionReceiptActionArgs type
  • moves convertYoctoToNearAndConsiderSmallAmountsToBeZero and getFinalCsvRow into transformations.ts
  • moves divideByPowerOfTen to external/fungibleTokenTools.ts (a placeholder for functions that are not specific to this repo and can be moved into an external library)
  • labels the datetime_utc as such (it's always important to be clear about time zones, and I'm not sure why the HH:mm:ss had gotten removed)
  • moves the datetime helper out to external (temporary location)
  • uses the official "utils" from near-api-js for conversion instead of us defining our own export const YOCTO_CONVERSION_CONSTANT = 10 ** 24;
  • adds some comments warning about precision loss
  • removes ACCOUNT_IDS from .env since that dev-only feature is no longer useful now that we're using localStorage

@ryancwalsh ryancwalsh marked this pull request as draft December 6, 2022 16:58
…h passes now that YOCTO_CONVERSION_CONSTANT is temporarily being used again
… us defining our own `YOCTO_CONVERSION_CONSTANT = 10 ** 24;`
@ryancwalsh ryancwalsh marked this pull request as ready for review December 6, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant