-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve translation code #64
Conversation
There are major issues. It was good to separate the code of the back-end, but their path was not corrected in the CI / CD configuration, so I confirmed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended to use basic grammar rather than default
Fixed #63
The translation library is changed, and the existing class method is changed to a function method for some components. (This is because
react-i18next
is directed to Hook Function)Currently, this homepage operates with two backends, API Server and
Firebase
, but the code is one, so I'm concerned about the confusion and separate the two codes for scalability.