Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for slurm script accordion #83

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bugfix for slurm script accordion #83

wants to merge 3 commits into from

Conversation

mlhenderson
Copy link
Contributor

This is a bugfix for issue #82

  • JSX.Element was deprecated, updated references with React.ReactElement
  • Added a custom toggle for the accordion, with a function that sets the inputType for the display logic of the Caret icon
  • Added an empty string state for when the eventKey is null, which happens if you deselect the active accordion element
  • Updated the default placeholder for the custom path input
  • ESlint formatting applied

* adding copier answers and manually updating github action files from template

* updated jupyterlab link in README

* lint updates

* lint updates, added awaits for async calls, move jobid sort

* change version

* fix version string

* fix version string

* apply prettier updates

* apply stylelint updates

* diable tests for now

* adding changelog

* inserting basic test setup

* disable looking for unit tests in src

* update CHANGELOG contents for template

* update console message to satisfy ui test
@mlhenderson mlhenderson added the bug Something isn't working label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant