Rename variables to keep naming scheme #160
Conversation
|
I made this a draft because there are still some variables missing in the renaming. We'll discuss how to proceed with them in #159 |
We opened a discussion around that issue upstream: ansible/ansible-lint#3451 To move fast, we now put this on the warn_list and come back to it, when the discussion is resolved. Hopefully to remove the rule completly from `ansible-lint.yml`.
|
We opened a discussion around that issue upstream: ansible/ansible-lint#3451 To move fast, we now put this on the warn_list and come back to it, when |
There was a problem hiding this comment.
If the collection is accepted as prefix in the upstream discussion everything related to the CA shared by the complete stack should be prefixed elasticstack_, this goes for unchanged variables like elastic_ca_pass and some changed in the PR like elastic_ca_will_expire_soon/elasticsearch_ca_will_expire_soon. So I would keep thise unchanged until then.
|
@dgoetz I hope, I now caught all of the missing variables. Honestly, I feel a slight hint of panic when I think of merging this PR and all the others that are still open. 😱 |
|
Some of the checks are failing because of timeouts. As long as all |
|
@widhalmt woo It is a big type work ✍️ Thanks I see the PR is ok. The only suggestion is the above, there are three stack words in the variable name. You can take the suggestion or ignore it. |
Rename variable for better readability. Co-authored-by: Afeef Ghannam <39904920+afeefghannam89@users.noreply.github.com>
There was a problem hiding this comment.
Naming looks consistent now within the collection and with the guideline (including our proposed addition). It creates some clunky names but that seems unavoidable with the goal in mind. Nitpicking could be done in form of complaining some not being in alphabetical or logical order, but I am ok with this.
|
Some of them aren't in alphabetical order on purpose. I tried to group them logically. :-) |
fixes NETWAYS#159 --------- Co-authored-by: Afeef Ghannam <39904920+afeefghannam89@users.noreply.github.com>
3 participants
fixes #159