-
Notifications
You must be signed in to change notification settings - Fork 12
Enable ca/cert management #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Enable renew elasticsearch cert * Enable renew Logstash cert * Enable renew kibana cert * Enable renew beats cert * Let Logstash right data on disk * Prevent Logstash to stick by elasticsearch dead connection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love how you work with tags everywhere and how you use tags for one-shot runs like when renewing certificates.
I'm not 100% sure if renewing client certificates wouldn't make sense as a variable. This way you could just enable it and have them replaced as soon as they close in on the end of their validity.
Most comments are things I'm wondering and I'm not really sure if there needs to be a change. Please don't read them as a request for an actual change. It's more of a "did you have time to test"?
The only real changes I see are that handlers are missing (we talked about that offline) and the per queue setting (with global default) of queue type and size.
Thanks :) I like tags more than variable, because they are more flexible by management of changes, the user should not change any variable value when he would like to run a snippet of Ansible code. The variable will come later when we check the validity of certificate. This variable will be set to the conditions of certificate renew tasks. So the user does not have to manipulate any variable value, this will enforce automatism Principe |
* Remove extra line
507c02d
to
efc1e3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that was a big one to review. :-)
The only real change I can request is the missing "newline" character. The rest is more "I'm not sure, can you give me information about it". So I guess, it's very close to being finished.
The "boolean" for the queue type was just an idea. I guess, it's not worth editing everything again just for that.
Please merge |
* Fix logstash connction problem mit elasticserch when ca renew Logstash will not restart when the ca renew and elasticsearch log is full with client conntion certificate problem with logstash http client did not trust this server's certificate, closing connection Netty4HttpChannel
I fixed some lint so checks can go through. I'm right now testing this on a local system. |
Helps a bit with #22
Changing the Logstash certificate works for me. But only for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found one typo and 2 missing prefixes for variable names. Everything else looks not just good but excellent to me!
Trying solution suggested in ansible/ansible-lint#497
…nsible-collection-elasticstack into enhancement/renew_certificates
Merge queue setting changed
Merge queue setting changed
Merge queue setting changed
* Rework variables names * Enable security with full stack automatically fixes NETWAYS#46
* Enable renew CA * Enable renew Elasticsearch cert * Enable renew Logstash cert * Enable renew Kibana cert * Enable renew beats cert * Check CA and Certs validity date and renew them * Let Logstash write data on disk * Prevent Logstash to stick by Elasticsearch dead connection * Make sure certificate handling is idempotent and reacts to changes NETWAYS#35 * Make Kibana use its certificate and not share the on from elasticsearch NETWAYS#56 * Let Kibana start after reboot NETWAYS#57 NETWAYS#69 * Allow to use persisted queues per pipeline NETWAYS#60 * Restart the available beat service when create or renew certificates NETWAYS#83
Uh oh!
There was an error while loading. Please reload this page.