SLES 15.4 & GCC 7.5: Fixes on Compiler Warnings & Notes #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SLES 15.4 with guarding, indentation and unused variables
martialblog
reviewed
Dec 15, 2022
Remove last comment on "//static char **oid_ifp;" as it is unused.
|
Needs a review from someone who's more proficient in C than me. @RincewindsHat 👀 |
RincewindsHat
requested changes
Dec 22, 2022
Removed indendation on preprocessor macros, added on lines 908, 910, 920, 922
|
Looks good :-) Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes 5 warnings and one note on the GCC 7.5 Compiler of SLES 15.4 with guarding, indentation and unused variables.