Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/upgrade rubocop #36

Merged
merged 8 commits into from
Sep 10, 2020
Merged

Conversation

@iusztin iusztin requested a review from hiroara September 7, 2020 08:08
@iusztin iusztin force-pushed the chore/upgrade-rubocop branch from 42b4a9f to f770b81 Compare September 7, 2020 08:12
@iusztin
Copy link
Member Author

iusztin commented Sep 7, 2020

@hiroara Is there some place on GH where we could disable the Ruby-23 check? I can't see the setting. Could it be access restricted?

@iusztin
Copy link
Member Author

iusztin commented Sep 7, 2020

@NEWROPE/dev I disabled the Ruby 2.3 check. This PR is ready for review. Please take a look :)

Copy link
Member

@hiroara hiroara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for upgrading deps :)
But, could you also update code or rules to avoid committing .rubocop_todo.yml?

@iusztin iusztin changed the title Chore/upgrade rubocop [WIP]Chore/upgrade rubocop Sep 7, 2020
- and

RSpec/MultipleMemoizedHelpers:
Max: 7
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we use a lot of let in this project, I chose 7 to avoid most of our use cases (default is 5) and applied code changes to the rest.

For more details about this change by Rubocop-Rspec:
- rubocop/rubocop-rspec#863
- rubocop/rubocop-rspec#862
- https://thoughtbot.com/blog/lets-not

@iusztin iusztin changed the title [WIP]Chore/upgrade rubocop Chore/upgrade rubocop Sep 9, 2020
@iusztin iusztin changed the title Chore/upgrade rubocop [WIP] Chore/upgrade rubocop Sep 9, 2020
@iusztin iusztin changed the title [WIP] Chore/upgrade rubocop Chore/upgrade rubocop Sep 9, 2020
@iusztin
Copy link
Member Author

iusztin commented Sep 9, 2020

@NEWROPE/dev I pushed changes. Please take a look again :) (Though dependabot seems to be stuck at WIP? lol)

@@ -24,4 +23,6 @@ Gem::Specification.new do |spec|
spec.require_paths = ['lib']

spec.add_development_dependency 'bundler', '~> 2.1'

spec.required_ruby_version = '>= 2.4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this constraint :)

Copy link
Member

@hiroara hiroara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Since we dropped support for an old version of ruby, let's bump the major version 👍

@hiroara hiroara merged commit 7354131 into NEWROPE:master Sep 10, 2020
@RobertMaciejewski RobertMaciejewski mentioned this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants