Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniMessage TranslatableComponent not detecting player's locale #1399

Closed
4 of 5 tasks
AnleaR opened this issue Dec 10, 2024 · 5 comments
Closed
4 of 5 tasks

MiniMessage TranslatableComponent not detecting player's locale #1399

AnleaR opened this issue Dec 10, 2024 · 5 comments
Labels
Resolution: Added / Fixed Feature added / issue was fixed Type: Bug Plugin is not working as described on the wiki
Milestone

Comments

@AnleaR
Copy link

AnleaR commented Dec 10, 2024

Server version

Paper 1.20.4

TAB version

5.0.3

Plugin list

I think it doesn't matter in this bug.

Describe the bug

When I'm trying to use TranslatableComponents from MiniMessage in TAB, plugin transforms components only into English locale.

Expected behavior

The plugin must take into account the localization of the player. Or rather, to support TranslatableComponent from MiniMessage.

Steps to reproduce

Step 1: place in any scoreboard line this text lang:entity.minecraft.chicken
Step 2: reload the plugin
Step 3: select any language except English

Additional info

Screenshot: https://imgur.com/a/Umw7aDo

Checklist

  • I am running latest version of the plugin
  • I have read the wiki to make sure it's not an issue with configuration
  • I ticked all of the boxes without actually reading them
  • I have read the Compatibility wiki page and am not trying to run the plugin on an unsupported server version / platform
  • I am willing to cooperate to get this issue resolved faster, including providing any additional information requested or testing new builds
@AnleaR AnleaR added the Type: Bug Plugin is not working as described on the wiki label Dec 10, 2024
@NEZNAMY
Copy link
Owner

NEZNAMY commented Dec 10, 2024

TAB does not support translatable components. That's not a bug.

@AnleaR
Copy link
Author

AnleaR commented Dec 10, 2024

TAB does not support translatable components. That's not a bug.

I read FAQ and I know this. May be I selected wrong category for this issue?
I want to make TranslatableComponents work in TAB. Can I contribute to solve this issue?

@NEZNAMY
Copy link
Owner

NEZNAMY commented Dec 10, 2024

image
Your request would require a large amount of changes, so I don't recommend trying to add it yourself.

@AnleaR
Copy link
Author

AnleaR commented Dec 10, 2024

Simple MiniMessage support already includes TranslatableComponents. I don't think it will be difficult to implement.
Okay, can you transfer my issue into Feature Requests?

@NEZNAMY
Copy link
Owner

NEZNAMY commented Dec 10, 2024

Feature requests are closed like I already said.

@AnleaR AnleaR closed this as completed Dec 11, 2024
@AnleaR AnleaR closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
@NEZNAMY NEZNAMY added the Resolution: Added / Fixed Feature added / issue was fixed label Dec 13, 2024
@NEZNAMY NEZNAMY added this to the 5.0.4 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Added / Fixed Feature added / issue was fixed Type: Bug Plugin is not working as described on the wiki
Projects
None yet
Development

No branches or pull requests

2 participants