Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stream! error when :from is greater than the last event number #68

Merged
merged 1 commit into from
May 26, 2022
Merged

Fix stream! error when :from is greater than the last event number #68

merged 1 commit into from
May 26, 2022

Conversation

bminevsb
Copy link
Contributor

Fix for #67

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7e832a436c184d693db80e19ee9a942ce400b0a9-PR-68

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build a2b9a6ac5de6cf74ae2f6f7c336c8b9efe10219e: 0.0%
Covered Lines: 642
Relevant Lines: 642
💛 - Coveralls

the-mikedavis
the-mikedavis approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the fix!

@the-mikedavis the-mikedavis merged commit 7e832a4 into NFIBrokerage:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bminevsb @coveralls @the-mikedavis