Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token counts for deleted tokens #157

Closed
awfm9 opened this issue Jun 20, 2022 · 2 comments
Closed

Fix token counts for deleted tokens #157

awfm9 opened this issue Jun 20, 2022 · 2 comments

Comments

@awfm9
Copy link
Contributor

awfm9 commented Jun 20, 2022

When a token was deleted, i.e. we can't retrieve its details on IPFS / the HTTP server, we don't properly add the token count to the database. When a token is then transferred away from a person, it leads to a -1 entry.

The same happens when collections than re-use token IDs creates the token a second time. It might lead to entries of 2, 3 and higher if the token is transferred to the same address multiple times.

@awfm9
Copy link
Contributor Author

awfm9 commented Jun 30, 2022

This can be solved by applying the addition of the owner count on the parsing job right away, just like we do for transfers.

@awfm9
Copy link
Contributor Author

awfm9 commented Jul 1, 2022

Done in #164

@awfm9 awfm9 closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant