Make owner count changes idempotent #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
models/id/event.go
Outdated
| "golang.org/x/crypto/sha3" | ||
| ) | ||
|
|
||
| func Event(hash string, index uint) string { |
There was a problem hiding this comment.
I don't think we should name the first parameter hash as it makes readers read as event hash and not transaction hash. WDYT?
awfm9
force-pushed
the
make-owner-operations-idempotent
branch
from
292dc94 to
3acedaf
Compare
awfm9
force-pushed
the
make-owner-operations-idempotent
branch
from
8a6eec7 to
dae6def
Compare
awfm9
force-pushed
the
make-owner-operations-idempotent
branch
2 times, most recently
from
44e01c8 to
d68a4db
Compare
awfm9
force-pushed
the
make-owner-operations-idempotent
branch
from
d68a4db to
5878090
Compare
This was referenced Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to make every owner change in itself uniquely identifiable in the SQL table. This means that if the same owner change is processed multiple times, we will trigger the conflict clause in the SQL and simply do nothing.
For retrieval of owner counts, we simply have to select the sum by owner address and/or NFT ID, which will automatically include all the relevant rows.