Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nz-select] Allow nz-select open with spacebar when focused, like the default HTML select #1909

Closed
DouglasOGarrido opened this issue Aug 1, 2018 · 2 comments · Fixed by #2038
Closed

[nz-select] Allow nz-select open with spacebar when focused, like the default HTML select #1909

DouglasOGarrido opened this issue Aug 1, 2018 · 2 comments · Fixed by #2038
Assignees
@wzhudev
Labels
💪 Enhancement

Comments

@DouglasOGarrido
Copy link

What problem does this feature solve?

The select component doesn't open when press spacebar key.

What does the proposed API look like?

Allow nz-select open with spacebar when focused, like the default HTML select.

Example: W3Schools Select Tag
@DouglasOGarrido DouglasOGarrido changed the title [nz.-select] Allow nz-select open with spacebar when focused, like the default HTML select [nz-select] Allow nz-select open with spacebar when focused, like the default HTML select Aug 1, 2018
@wzhudev wzhudev self-assigned this Aug 2, 2018
@wzhudev wzhudev mentioned this issue Aug 8, 2018
Closed
@wzhudev wzhudev mentioned this issue Aug 15, 2018
Closed
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Aug 24, 2018
feat(module:select): support open and close panel via keyboard
fc97801 
close NG-ZORRO#1909
@wzhudev wzhudev mentioned this issue Aug 24, 2018
Merged
3 tasks
simplejason pushed a commit that referenced this issue Sep 7, 2018
feat(module:select): support open and close panel via keyboard (#2038)
b2ea96a 
close #1909
@Devvarat
Copy link

Devvarat commented Oct 3, 2018

This creates a new issue with the nz-select with search. Now you can not type space while writing search text in select.
nz-zorro behaiviour: https://ng.ant.design/components/select/en#components-select-demo-select-users
ant-design(react): https://ant.design/components/select/#components-select-demo-select-users

@vthinkxie vthinkxie reopened this Oct 4, 2018
@wzhudev
Copy link
Member

wzhudev commented Oct 4, 2018 •
edited
Loading

Duplicates #2201. This would be closed now. Please track the problem in 2201.

@wzhudev wzhudev closed this as completed Oct 4, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
feat(module:select): support open and close panel via keyboard (NG-ZO…
f3f460d 
…RRO#2038)

close NG-ZORRO#1909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wzhudev wzhudev

Labels
💪 Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(module:select): support open and close panel via keyboard wzhudev/ng-zorro-antd
4 participants
@vthinkxie @Devvarat @DouglasOGarrido @wzhudev