Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collapse: add extra to nz-collapse-panel #1911

Closed
wzhudev opened this issue Aug 2, 2018 · 2 comments · Fixed by #2923
Closed

collapse: add extra to nz-collapse-panel #1911

wzhudev opened this issue Aug 2, 2018 · 2 comments · Fixed by #2923
Assignees
@wzhudev
Labels
Component: Collapse 🌈 Feature Request

Comments

@wzhudev
Copy link
Member

wzhudev commented Aug 2, 2018

What problem does this feature solve?

What if users have operations on a collapse panel or all components it contains? It would be a considerate API for developers.

What does the proposed API look like?

<nz-collapse-panel nz-col *ngFor="let row of structure.rows" [nzHeader]="collapseHeader" [nzExtra]="collapseExtra" [(nzActive)]="row.active">
</nz-collapse-panel>

<ng-template #collapseExtra>
  <!-- nz-menu or something -->
</ng-template>
@wzhudev wzhudev changed the title [Feature Request] Add extra template support to nz-collapse-panel [feature request: nz-collapse] add extra template support to nz-collapse-panel Aug 2, 2018
@wzhudev wzhudev self-assigned this Aug 2, 2018
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Aug 2, 2018
feat(module:collapse): add extra support
e5870a4 
close NG-ZORRO#1911
@wzhudev wzhudev mentioned this issue Aug 2, 2018
Closed
3 tasks
@wzhudev
Copy link
Member Author

wzhudev commented Aug 3, 2018

Should implement after ant design react do the same.

@wzhudev wzhudev closed this as completed Aug 3, 2018
@wzhudev
Copy link
Member Author

wzhudev commented Jan 29, 2019

Reopen. Ref react-component/collapse#103 (comment).

@wzhudev wzhudev reopened this Jan 29, 2019
@wzhudev wzhudev changed the title [feature request: nz-collapse] add extra template support to nz-collapse-panel collapse: add extra to nz-collapse-panel Jan 29, 2019
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Feb 19, 2019
feat(module:collapse): add extra field
58927d9 
close NG-ZORRO#1911
@wzhudev wzhudev mentioned this issue Feb 19, 2019
Merged
3 tasks
vthinkxie pushed a commit that referenced this issue Feb 19, 2019
@vthinkxie
feat(module:collapse): add extra field (#2923)
dd0cec2 
* feat(module:collapse): add extra field
close #1911

* test: add test
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@Ricbet
feat(module:collapse): add extra field (NG-ZORRO#2923)
4b238cc 
* feat(module:collapse): add extra field
close NG-ZORRO#1911

* test: add test
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@vthinkxie
feat(module:collapse): add extra field (NG-ZORRO#2923)
2ac8a54 
* feat(module:collapse): add extra field
close NG-ZORRO#1911

* test: add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wzhudev wzhudev

Labels
Component: Collapse 🌈 Feature Request
Projects
None yet
Milestone
No milestone
2 participants
@vthinkxie @wzhudev