fix(module:progress): should not set success when success percent is … #3135
+171
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 178d0b4 |
Codecov Report
@@ Coverage Diff @@
## master #3135 +/- ##
==========================================
- Coverage 97.34% 97.33% -0.01%
==========================================
Files 552 552
Lines 11587 11558 -29
Branches 827 835 +8
==========================================
- Hits 11279 11250 -29
Misses 195 195
Partials 113 113
Continue to review full report at Codecov.
|
|
Deploy preview for ng-zorro-master ready! Built with commit 7069f62 |
hsuanxyz
reviewed
Mar 27, 2019
hsuanxyz
approved these changes
Mar 27, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
NG-ZORRO#3135) * fix(module:progress): should not set success when success percent is given close 3128 * feat: add encapsulation * revert: revert package.json * revert: test.ts * fix: fix icon not removed
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
NG-ZORRO#3135) * fix(module:progress): should not set success when success percent is given close 3128 * feat: add encapsulation * revert: revert package.json * revert: test.ts * fix: fix icon not removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…given
close #3128
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3128
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Also refactor this component and add a demo.