Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: publish sourcemap in release #662

Closed
trotyl opened this issue Dec 2, 2017 · 1 comment · Fixed by #666
Closed

build: publish sourcemap in release #662

trotyl opened this issue Dec 2, 2017 · 1 comment · Fixed by #666
Assignees
@trotyl
Labels
💪 Enhancement

Comments

@trotyl
Copy link
Contributor

trotyl commented Dec 2, 2017 •
edited
Loading

What problem does this feature solve?

Current build process:

             ngc                           rollup                        tsc                     rollup                     uglify
ts (source) ----> js (esm2015, separated) -------> js (esm2015, bundle) ----> js (esm5, bundle) -------> js (umd5, bundle) -------> js (umd5, bundle, min)

The tsc step makes it impossible to generate sourcemap for es5 target (tsc cannot consume input sourcemap).

Should be changed to:

             ngc                           rollup
ts (source) ----> js (esm2015, separated) -------> js (esm2015, bundle)
           | ngc                        rollup
           |----> js (esm5, separated) -------> js (esm5, bundle)
                                      | rollup
                                      |-------> js (umd5, bundle)
                                      | rollup
                                      |-------> js (umd5, bundle, min)

What does the proposed API look like?

N/A.
@trotyl trotyl self-assigned this Dec 2, 2017
@trotyl trotyl mentioned this issue Dec 2, 2017
Merged
3 tasks
vthinkxie pushed a commit that referenced this issue Dec 6, 2017
@trotyl @vthinkxie
feat(packaging): generate sourcemaps (#666)
8665639 
Closes #662
BREAKING CHANGE: umd file name simplified from 'ng-zorro-antd.js' to 'antd.js'
@lock
Copy link

lock bot commented Feb 18, 2019

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2019
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@trotyl @vthinkxie
feat(packaging): generate sourcemaps (NG-ZORRO#666)
666f636 
Closes NG-ZORRO#662
BREAKING CHANGE: umd file name simplified from 'ng-zorro-antd.js' to 'antd.js'
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@trotyl trotyl

Labels
💪 Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(packaging): generate sourcemaps
1 participant
@trotyl