Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): support changing language at runtime #1768

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

wilsoncook
Copy link
Member

close #1717

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1717

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wilsoncook wilsoncook changed the title fix(module:date-picker): support changing language at runtime [WIP] fix(module:date-picker): support changing language at runtime Jul 2, 2018
@wilsoncook wilsoncook force-pushed the fix_datepicker_locale_change branch from e50e505 to 1f06de5 Compare July 2, 2018 12:09
@codecov
Copy link

codecov bot commented Jul 2, 2018

Codecov Report

Merging #1768 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1768      +/-   ##
==========================================
+ Coverage   96.05%   96.08%   +0.03%     
==========================================
  Files         466      466              
  Lines       11153    11169      +16     
  Branches     1458     1460       +2     
==========================================
+ Hits        10713    10732      +19     
+ Misses        127      126       -1     
+ Partials      313      311       -2
Impacted Files Coverage Δ
...omponents/date-picker/abstract-picker.component.ts 98.8% <100%> (+0.28%) ⬆️
components/time-picker/time-holder.ts 95.91% <0%> (-1.03%) ⬇️
...nents/date-picker/lib/date/date-table.component.ts 98.23% <0%> (+0.88%) ⬆️
components/table/nz-table.component.ts 95.93% <0%> (+1.16%) ⬆️
components/date-picker/lib/candy-date/util.ts 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92675e4...1f06de5. Read the comment docs.

@wilsoncook wilsoncook changed the title [WIP] fix(module:date-picker): support changing language at runtime fix(module:date-picker): support changing language at runtime Jul 2, 2018
@wilsoncook wilsoncook requested a review from vthinkxie July 2, 2018 13:43
@vthinkxie vthinkxie merged commit 9caabb5 into NG-ZORRO:master Jul 2, 2018
@wilsoncook wilsoncook deleted the fix_datepicker_locale_change branch July 23, 2018 12:00
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datepicker can not change language dynamically
2 participants