refactor(tree): support more functions & property #2121

simplejason · 2018-09-10T07:20:43Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:
#1928 #2000 #2062 #1888 #1836 #2168

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

API changes (just some important changes, more details can read doc)

before	current
[ngModel]	[nzData]
[nzDefaultExpandAll]	[nzExpandAll]
[nzDefaultExpandedKeys]	[nzExpandedKeys]
[nzDefaultCheckedKeys]	[nzCheckedKeys]
[nzDefaultSelectedKeys]	[nzSelectedKeys]
(nzOnSearchNode)	(nzSearchValueChange)

NzTreeFormatEmitEvent

before	current
selectedKeys: NzTreeNode[]	selectedKeys: string[]
checkedKeys: NzTreeNode[]	checkedKeys: string[]
matchededKeys: NzTreeNode[]	matchededKeys: string[]
matchededKeys: new	matchededKeys: string[]

Other information

codecov · 2018-09-10T07:34:07Z

Codecov Report

Merging #2121 into master will decrease coverage by 0.05%.
The diff coverage is 94.19%.

@@            Coverage Diff             @@
##           master    #2121      +/-   ##
==========================================
- Coverage      96%   95.95%   -0.06%     
==========================================
  Files         477      478       +1     
  Lines       11618    11709      +91     
  Branches     1550     1561      +11     
==========================================
+ Hits        11154    11235      +81     
- Misses        132      133       +1     
- Partials      332      341       +9

Impacted Files	Coverage Δ
components/tree/nz-tree.module.ts	`100% <ø> (ø)`	⬆️
components/tree/nz-tree-util.ts	`100% <100%> (ø)`
components/tree-select/nz-tree-select.component.ts	`97.76% <100%> (-0.9%)`	⬇️
components/tree/nz-tree-node.ts	`91.52% <88.46%> (-2.23%)`	⬇️
components/tree/nz-tree.service.ts	`93.6% <92.42%> (-2.08%)`	⬇️
components/tree/nz-tree-node.component.ts	`96.21% <96.06%> (+1.62%)`	⬆️
components/tree/nz-tree.component.ts	`98.01% <97.18%> (-1.99%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fde383...a134cb7. Read the comment docs.

codecov · 2018-09-19T01:43:43Z

Codecov Report

Merging #2121 into master will decrease coverage by 0.18%.
The diff coverage is 91.4%.

@@            Coverage Diff             @@
##           master    #2121      +/-   ##
==========================================
- Coverage   96.02%   95.83%   -0.19%     
==========================================
  Files         479      480       +1     
  Lines       11689    11817     +128     
  Branches     1563     1577      +14     
==========================================
+ Hits        11224    11325     +101     
- Misses        131      149      +18     
- Partials      334      343       +9

Impacted Files	Coverage Δ
components/tree/nz-tree.module.ts	`100% <ø> (ø)`	⬆️
components/tree/nz-tree-util.ts	`100% <100%> (ø)`
components/tree-select/nz-tree-select.component.ts	`97.76% <100%> (-0.9%)`	⬇️
components/tree/nz-tree.component.ts	`85.27% <82.02%> (-14.73%)`	⬇️
components/tree/nz-tree-node.ts	`91.52% <88.46%> (-2.23%)`	⬇️
components/tree/nz-tree.service.ts	`93.67% <92.42%> (-2%)`	⬇️
components/tree/nz-tree-node.component.ts	`96.33% <96.21%> (+1.74%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c70ff04...bfd01a4. Read the comment docs.

codecov · 2018-09-19T02:01:24Z

Codecov Report

Merging #2121 into master will decrease coverage by 0.18%.
The diff coverage is 91.4%.

@@            Coverage Diff             @@
##           master    #2121      +/-   ##
==========================================
- Coverage   96.02%   95.83%   -0.19%     
==========================================
  Files         479      480       +1     
  Lines       11689    11817     +128     
  Branches     1563     1577      +14     
==========================================
+ Hits        11224    11325     +101     
- Misses        131      149      +18     
- Partials      334      343       +9

Impacted Files	Coverage Δ
components/tree/nz-tree.module.ts	`100% <ø> (ø)`	⬆️
components/tree/nz-tree-util.ts	`100% <100%> (ø)`
components/tree-select/nz-tree-select.component.ts	`97.76% <100%> (-0.9%)`	⬇️
components/tree/nz-tree.component.ts	`85.27% <82.02%> (-14.73%)`	⬇️
components/tree/nz-tree-node.ts	`91.52% <88.46%> (-2.23%)`	⬇️
components/tree/nz-tree.service.ts	`93.67% <92.42%> (-2%)`	⬇️
components/tree/nz-tree-node.component.ts	`96.33% <96.21%> (+1.74%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c70ff04...a9acb66. Read the comment docs.

codecov · 2018-09-19T02:11:17Z

Codecov Report

Merging #2121 into master will decrease coverage by 0.03%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master    #2121      +/-   ##
==========================================
- Coverage      96%   95.96%   -0.04%     
==========================================
  Files         481      482       +1     
  Lines       11832    11965     +133     
  Branches     1580     1594      +14     
==========================================
+ Hits        11359    11482     +123     
- Misses        133      134       +1     
- Partials      340      349       +9

Impacted Files	Coverage Δ
components/tree/nz-tree.module.ts	`100% <ø> (ø)`	⬆️
components/tree/nz-tree-util.ts	`100% <100%> (ø)`
components/tree-select/nz-tree-select.component.ts	`97.76% <100%> (-0.9%)`	⬇️
components/tree/nz-tree.service.ts	`93.67% <92.42%> (-2%)`	⬇️
components/tree/nz-tree-node.ts	`92.18% <92.85%> (-1.57%)`	⬇️
components/tree/nz-tree-node.component.ts	`96.29% <96.15%> (+1.7%)`	⬆️
components/tree/nz-tree.component.ts	`98.47% <97.8%> (-1.53%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef8bcf...9a24e96. Read the comment docs.

refactor(tree): support more functions & property fix(tree): fix demo fix dir-tree fix doc fix doc fix(tree): support deprecated property fix(tree): fix interface fix(tree): fix param fix(tree): fix param fix(tree): fix spec fix(tree): fix spec fix(tree): fix origin fix(tree): support get all nodes fix(tree): fix demo fix(tree): fix doc fix(tree): fix doc fix(tree): fix deprecatedC fix(tree): fix deprecated fix(tree): fix deprecated fix(tree): fix spec fix(tree): fix console fix(tree): fix doc fix(tree): fix doc

close NG-ZORRO#1928 close NG-ZORRO#2000 close NG-ZORRO#2062 close NG-ZORRO#1888 close NG-ZORRO#1836 close NG-ZORRO#2168

simplejason changed the title ~~[WIP] refactor(tree): support more functions & property~~ refactor(tree): support more functions & property Sep 12, 2018

simplejason force-pushed the fix-tree branch 5 times, most recently from c5396d4 to 39959eb Compare September 17, 2018 12:11

simplejason changed the title ~~refactor(tree): support more functions & property~~ [WIP] refactor(tree): support more functions & property Sep 18, 2018

simplejason force-pushed the fix-tree branch from f3e90f4 to bfd01a4 Compare September 19, 2018 01:43

simplejason force-pushed the fix-tree branch from a9acb66 to 7e7e794 Compare September 19, 2018 02:11

simplejason force-pushed the fix-tree branch from 2db1037 to 96b5749 Compare September 19, 2018 12:37

simplejason changed the title ~~[WIP] refactor(tree): support more functions & property~~ refactor(tree): support more functions & property Sep 20, 2018

simplejason force-pushed the fix-tree branch 3 times, most recently from 25d0fd9 to b2482ac Compare September 20, 2018 04:30

simplejason mentioned this pull request Sep 20, 2018

TREE数据获取 #2168

Closed

simplejason force-pushed the fix-tree branch 2 times, most recently from 72925e2 to 3255ba3 Compare September 21, 2018 01:48

vthinkxie requested a review from hsuanxyz September 21, 2018 10:18

simplejason force-pushed the fix-tree branch 5 times, most recently from d55f8d0 to 6e7c141 Compare September 21, 2018 13:14

simplejason force-pushed the fix-tree branch from 6e7c141 to 9a24e96 Compare September 21, 2018 13:18

vthinkxie merged commit c4317cc into NG-ZORRO:master Sep 22, 2018

hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020

refactor(tree): support more functions & property (NG-ZORRO#2121)

0be9485

close NG-ZORRO#1928 close NG-ZORRO#2000 close NG-ZORRO#2062 close NG-ZORRO#1888 close NG-ZORRO#1836 close NG-ZORRO#2168

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(tree): support more functions & property #2121

refactor(tree): support more functions & property #2121

simplejason commented Sep 10, 2018 •

edited

Loading

codecov bot commented Sep 10, 2018 •

edited

Loading

codecov bot commented Sep 19, 2018

codecov bot commented Sep 19, 2018

codecov bot commented Sep 19, 2018 •

edited

Loading

refactor(tree): support more functions & property #2121

refactor(tree): support more functions & property #2121

Conversation

simplejason commented Sep 10, 2018 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

API changes (just some important changes, more details can read doc)

Other information

codecov bot commented Sep 10, 2018 • edited Loading

Codecov Report

codecov bot commented Sep 19, 2018

Codecov Report

codecov bot commented Sep 19, 2018

Codecov Report

codecov bot commented Sep 19, 2018 • edited Loading

Codecov Report

simplejason commented Sep 10, 2018 •

edited

Loading

codecov bot commented Sep 10, 2018 •

edited

Loading

codecov bot commented Sep 19, 2018 •

edited

Loading