Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:popconfirm): fix icon disappear when nzTitle is a TemplateRef instance #2463

Closed
wants to merge 1 commit into from

Conversation

WOOOFEI
Copy link

@WOOOFEI WOOOFEI commented Nov 15, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Icon disappears when nzTitle is a TemplateRef instance.

Issue Number: N/A

What is the new behavior?

Icon won't disappear when nzTitle is a TemplateRef instance.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #2463 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2463   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         487      487           
  Lines       12318    12318           
  Branches     1663     1663           
=======================================
  Hits        11806    11806           
  Misses        152      152           
  Partials      360      360

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b8f9ea...27b6727. Read the comment docs.

@vthinkxie
Copy link
Member

Hi @WOOOFEI ,
thanks for your pr
but this is not a bug, it provides the chance to rewrite the icon.

@vthinkxie vthinkxie closed this Nov 15, 2018
@WOOOFEI
Copy link
Author

WOOOFEI commented Nov 15, 2018

I'm handling with #2196, shall I add this change to that branch or just stay the same?

@wzhudev
Copy link
Member

wzhudev commented Nov 15, 2018

@WOOOFEI This would introduce breaking change. Maybe we should fix it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants