-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update dependency version #2798
Conversation
Deploy preview for ng-zorro-master ready! Built with commit b663d10 |
Codecov Report
@@ Coverage Diff @@
## master #2798 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 518 518
Lines 12292 12292
Branches 1697 1697
=======================================
Hits 11741 11741
Misses 191 191
Partials 360 360 Continue to review full report at Codecov.
|
Notice for our contributors: Break building and testing on Windows because of Typescript's bug. See: microsoft/TypeScript#29221. Please downgrade to 3.1.3 locally for now. |
@wendzhue Hi! Could you maybe place that last note in the home README? |
@lppedd TypeScript closed that issue and claimed that this issue had been fixed. (Personally I doubt about it.) I may not put the link in README.md because this is irrelevant to most users. So I am going to create a wiki page listing all problems that contributors may run into. Thanks for your suggestion anyway. ❤️ |
@wendzhue Thank you very much!
|
@lppedd Added, thanks! |
@lppedd Maybe it has been fixed already by this PR? https://github.com/NG-ZORRO/ng-zorro-antd/pull/3807/files#diff-1e5b1f6a23b6ccd3b682a1513587cb33R2 |
@wendzhue yep, there it is. Awesome! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information