Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update dependency version #2798

Merged
merged 1 commit into from
Jan 17, 2019
Merged

build: update dependency version #2798

merged 1 commit into from
Jan 17, 2019

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Jan 17, 2019

Deploy preview for ng-zorro-master ready!

Built with commit b663d10

https://deploy-preview-2798--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #2798 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2798   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files         518      518           
  Lines       12292    12292           
  Branches     1697     1697           
=======================================
  Hits        11741    11741           
  Misses        191      191           
  Partials      360      360

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c41715...b663d10. Read the comment docs.

@vthinkxie vthinkxie merged commit 852ad73 into NG-ZORRO:master Jan 17, 2019
@wzhudev
Copy link
Member

wzhudev commented Jan 17, 2019

Notice for our contributors:

Break building and testing on Windows because of Typescript's bug. See: microsoft/TypeScript#29221. Please downgrade to 3.1.3 locally for now.

@lppedd
Copy link
Contributor

lppedd commented Jul 16, 2019

@wendzhue Hi! Could you maybe place that last note in the home README?
I was trying to let JetBrains reproduce an issue here and it took a while to figure out what was happening.

@wzhudev
Copy link
Member

wzhudev commented Jul 18, 2019

@lppedd TypeScript closed that issue and claimed that this issue had been fixed. (Personally I doubt about it.)

I may not put the link in README.md because this is irrelevant to most users. So I am going to create a wiki page listing all problems that contributors may run into. Thanks for your suggestion anyway. ❤️

@wzhudev
Copy link
Member

wzhudev commented Jul 18, 2019

@lppedd
Copy link
Contributor

lppedd commented Jul 18, 2019

@wendzhue Thank you very much!
Maybe you could add an error example, e.g.

error TS2742: The inferred type of 'variableName' cannot be named without a reference to '..module/path'. This is likely not portable. A type annotation is necessary.

@wzhudev
Copy link
Member

wzhudev commented Jul 18, 2019

@lppedd Added, thanks!

@wzhudev
Copy link
Member

wzhudev commented Jul 18, 2019

@lppedd
Copy link
Contributor

lppedd commented Jul 18, 2019

@wendzhue yep, there it is. Awesome!

Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants