Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tree): fix nzCheckStrictly and nzShowIcon and remove #2805

Closed
wants to merge 1 commit into from

Conversation

simplejason
Copy link
Member

@simplejason simplejason commented Jan 18, 2019

fix(module: tree): fix nzCheckStrictly nzShowIcon and remove

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1399 #2370 #2655 #2724

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jan 18, 2019

Deploy preview for ng-zorro-master ready!

Built with commit a8c6871

https://deploy-preview-2805--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #2805 into master will increase coverage by <.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2805      +/-   ##
==========================================
+ Coverage   95.53%   95.53%   +<.01%     
==========================================
  Files         517      517              
  Lines       12264    12277      +13     
  Branches     1692     1694       +2     
==========================================
+ Hits        11716    11729      +13     
  Misses        189      189              
  Partials      359      359
Impacted Files Coverage Δ
components/tree/nz-tree.component.ts 95.23% <100%> (+0.11%) ⬆️
components/tree/nz-tree-node.component.ts 95.32% <100%> (+0.02%) ⬆️
components/tree/nz-tree-node.ts 91.78% <90%> (-0.41%) ⬇️
components/time-picker/time-holder.ts 96.93% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6dfbd9...a8c6871. Read the comment docs.

fix(module: tree): fix nzCheckStrictly & add remove & fix nzShowIcon

fix(module: tree): fix spec & nzCheckStrictly

fix(module: tree): fix spec & nzCheckStrictly
@simplejason simplejason changed the title [WIP] fix(module: tree): fix tree bugs fix(module: tree): fix nzCheckStrictly and nzShowIcon and remove Jan 25, 2019
@simplejason simplejason requested a review from hsuanxyz January 31, 2019 03:05
@@ -617,6 +620,7 @@ export class NzTestTreeBasicControlledComponent {
}, {
title : '0-1',
key : '0-1',
icon : 'anticon anticon-frown-o',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use the new API, like just frown. Because old API is not suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants