Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:avatar): add loading and fetchpriority attributes #7347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Apr 4, 2022

Closes #7274

@arturovt arturovt requested a review from hsuanxyz as a code owner April 4, 2022 17:53
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (512a577) to head (f43d6f2).
Report is 33 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7347   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         534      534           
  Lines       18425    18425           
  Branches     2815     2815           
=======================================
  Hits        16858    16858           
  Misses       1246     1246           
  Partials      321      321           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arturovt arturovt force-pushed the feat/avatar-loading-fetch branch from f6ceba2 to a9734bd Compare April 5, 2022 09:22
@simplejason
Copy link
Member

As caniuse->loading and caniuse->fetchpriority shown, these attributes have low compatibility for most browsers, I don't think we need built-in properties to support. What do you think about this @hsuanxyz ?

@arturovt arturovt force-pushed the feat/avatar-loading-fetch branch from a9734bd to f43d6f2 Compare June 12, 2024 18:26
@Laffery Laffery added 🌐 caniuse blocked by browser compatibility Component: Avatar labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loading="lazy" to Avatar img element
3 participants