-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(module:*): use ECMAScript standard class field #8718
refactor(module:*): use ECMAScript standard class field #8718
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8718 +/- ##
==========================================
+ Coverage 91.91% 91.92% +0.01%
==========================================
Files 555 555
Lines 19717 19708 -9
Branches 2946 2944 -2
==========================================
- Hits 18122 18116 -6
+ Misses 1268 1266 -2
+ Partials 327 326 -1 ☔ View full report in Codecov by Sentry. |
46cd537
to
a163c14
Compare
hi @HyperLife1119, this PR is ready, I'd appreciate it if you could take a look on it ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
12a3101
to
1bb0496
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: close #8660
What is the new behavior?
useDefineForClassFields: false
in tsconfig.json has been removed, andDoes this PR introduce a breaking change?
Other information