Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:*): use ECMAScript standard class field #8718

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

Laffery
Copy link
Collaborator

@Laffery Laffery commented Aug 28, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: close #8660

What is the new behavior?

useDefineForClassFields: false in tsconfig.json has been removed, and

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Aug 28, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 97.53086% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.92%. Comparing base (5898da7) to head (1bb0496).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
components/date-picker/lib/date-table.component.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8718      +/-   ##
==========================================
+ Coverage   91.91%   91.92%   +0.01%     
==========================================
  Files         555      555              
  Lines       19717    19708       -9     
  Branches     2946     2944       -2     
==========================================
- Hits        18122    18116       -6     
+ Misses       1268     1266       -2     
+ Partials      327      326       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119 HyperLife1119 added this to the v19 milestone Sep 11, 2024
@HyperLife1119 HyperLife1119 modified the milestones: v19, v19.1 Dec 4, 2024
@Laffery Laffery force-pushed the feat/useDefineForClassFields branch from 46cd537 to a163c14 Compare January 14, 2025 05:38
@Laffery Laffery marked this pull request as ready for review January 14, 2025 06:20
@Laffery Laffery requested a review from HyperLife1119 January 14, 2025 06:20
@Laffery
Copy link
Collaborator Author

Laffery commented Jan 14, 2025

hi @HyperLife1119, this PR is ready, I'd appreciate it if you could take a look on it !

components/message/message.spec.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery force-pushed the feat/useDefineForClassFields branch from 12a3101 to 1bb0496 Compare January 16, 2025 03:20
@Laffery Laffery merged commit f1d8d92 into NG-ZORRO:master Jan 16, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants