Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:button): migrate demo to standalone mode #8740

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Laffery
Copy link
Collaborator

@Laffery Laffery commented Sep 10, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Laffery Laffery requested a review from vthinkxie as a code owner September 10, 2024 12:23
Copy link

zorro-bot bot commented Sep 10, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (1d4fa69) to head (6425284).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8740      +/-   ##
==========================================
+ Coverage   91.66%   93.15%   +1.49%     
==========================================
  Files         538      538              
  Lines       18457    18457              
  Branches     2816     2816              
==========================================
+ Hits        16918    17194     +276     
+ Misses       1226     1225       -1     
+ Partials      313       38     -275     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 merged commit 99b6b15 into NG-ZORRO:master Sep 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants