Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:carousel): carousel not working correctly in rtl mode #8770

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • [✔] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

In RTL mode, there are some issues with the Carousel component.
For some weird resone, when you change the direction of the document side to RTL, the directionality.change is not emitted; so in the document site you can not see the bugs, This is a recording of the produced bug in the RTL mode.

Carousel-bug.mp4

What is the new behavior?

The footage for the fixed behavior in the RTL mode:

Carousel-fixed.mp4

Does this PR introduce a breaking change?

  • Yes
  • [✔] No

Other information

🔶 NOTES:

  • The onLiClick is not required any more.
  • I used [dir]="'ltr'" and didn't put it in the style files becase Ant also gives it as an inline attribute on the HTML:

image

Copy link

zorro-bot bot commented Sep 18, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (dd42ad9) to head (18f5045).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8770   +/-   ##
=======================================
  Coverage   93.15%   93.15%           
=======================================
  Files         538      538           
  Lines       18457    18453    -4     
  Branches     2816     2815    -1     
=======================================
- Hits        17193    17190    -3     
+ Misses       1226     1225    -1     
  Partials       38       38           
Flag Coverage Δ
93.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laffery Laffery added Component: Carousel PR: target-minor PR: need-test Test is necessary for code changes. labels Sep 19, 2024
@Laffery Laffery added PR: target-minor PR: need-test Test is necessary for code changes. labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants