-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:select): fast scroll causes the scroll to bottom to misbehave #8771
Open
ParsaArvanehPA
wants to merge
24
commits into
NG-ZORRO:master
Choose a base branch
from
ParsaArvanehPA:feature/scroll-into-bottom-not-working-correctly
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(module:select): fast scroll causes the scroll to bottom to misbehave #8771
ParsaArvanehPA
wants to merge
24
commits into
NG-ZORRO:master
from
ParsaArvanehPA:feature/scroll-into-bottom-not-working-correctly
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8771 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 538 538
Lines 18457 18457
Branches 2816 2816
=======================================
Hits 17193 17193
Misses 1226 1226
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fast scrolling causes CDK's
scrolledIndexChange
to not report some one the indexes(most probably they use a debouneTime on their observable).By checking the relative index instead of the absolute index the issue can be fixed.
Issue Number: #8752
What is the new behavior?
Does this PR introduce a breaking change?
Other information