Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): fast scroll causes the scroll to bottom to misbehave #8771

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • [✔] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Fast scrolling causes CDK's scrolledIndexChange to not report some one the indexes(most probably they use a debouneTime on their observable).
By checking the relative index instead of the absolute index the issue can be fixed.

Issue Number: #8752

What is the new behavior?

Does this PR introduce a breaking change?

  • [✔] Yes
  • No

Other information

Copy link

zorro-bot bot commented Sep 18, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (dd42ad9) to head (e91b734).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8771   +/-   ##
=======================================
  Coverage   93.15%   93.15%           
=======================================
  Files         538      538           
  Lines       18457    18457           
  Branches     2816     2816           
=======================================
  Hits        17193    17193           
  Misses       1226     1226           
  Partials       38       38           
Flag Coverage Δ
93.15% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants