Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:icon): support nz-icon tag selector #8778

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Sep 21, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

新版本更推荐使用 <nz-icon> 而非 <span nz-icon>,前者更简短清晰,且支持自闭合。

+ <nz-icon nzType="smile" />
- <span nz-icon nzType="smile"></span>

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Sep 21, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (c64e1a1) to head (63b578b).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8778      +/-   ##
==========================================
+ Coverage   91.67%   93.15%   +1.48%     
==========================================
  Files         538      538              
  Lines       18457    18457              
  Branches     2816     2816              
==========================================
+ Hits        16920    17194     +274     
  Misses       1225     1225              
+ Partials      312       38     -274     
Flag Coverage Δ
93.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants