Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(module:auto-complete): added missing tests #8780

Merged

Conversation

ParsaArvanehPA
Copy link
Contributor

@ParsaArvanehPA ParsaArvanehPA commented Sep 22, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • [✔] Other... Please describe: missing unit tests for the Auto-complete Component

What is the current behavior?

What is the new behavior?

Before After
Statements 97.31% 98.65%
Branches 98.31% 100%
Functions 95.78% 96.84%
Lines 97.9% 99.3%

Does this PR introduce a breaking change?

  • Yes
  • [✔] No

Other information

Copy link

zorro-bot bot commented Sep 22, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (dd42ad9) to head (ed0f139).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8780      +/-   ##
==========================================
+ Coverage   93.15%   93.17%   +0.02%     
==========================================
  Files         538      538              
  Lines       18457    18457              
  Branches     2816     2816              
==========================================
+ Hits        17193    17198       +5     
+ Misses       1226     1221       -5     
  Partials       38       38              
Flag Coverage Δ
93.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit f9f7b9e into NG-ZORRO:master Sep 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants