Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(module:message,notification): update import usages #8802

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HyperLife1119
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

更新了这两个组件的导入用法。

由于 NzMessageService 与 NzNotificationService 都是在 root 中提供的(providedIn: 'root'),并且这两个组件都是 standalone 的,因此不再需要导入对应的 NgModule 即可使用。

弃用这两个组件对应的 NgModule,无论是在 standalone 还是非 standalone 的应用中,这两个 NgModule 都是不必要的。

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Sep 27, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (bbac457) to head (a819132).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8802      +/-   ##
==========================================
+ Coverage   91.76%   91.78%   +0.01%     
==========================================
  Files         536      536              
  Lines       18455    18455              
  Branches     2816     2816              
==========================================
+ Hits        16935    16938       +3     
+ Misses       1210     1208       -2     
+ Partials      310      309       -1     
Flag Coverage Δ
91.78% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants