-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:image): should close image preview if escape key to pressed #8809
base: master
Are you sure you want to change the base?
feat(module:image): should close image preview if escape key to pressed #8809
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8809 +/- ##
==========================================
+ Coverage 91.78% 91.84% +0.06%
==========================================
Files 536 536
Lines 18455 18462 +7
Branches 2816 2817 +1
==========================================
+ Hits 16939 16957 +18
+ Misses 1207 1197 -10
+ Partials 309 308 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Like Ant Design, we should be able to close image preview by pressing Escape key.
What is the new behavior?
Closes the image preview when Escapse is clicked.
Does this PR introduce a breaking change?
Other information