Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:*): cancel support for HTML string rendering #8831

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Oct 9, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

移除一些组件内部支持渲染 HTML 字符串的功能,因为这是非良好的模式。message, notification,modal 组件除外,因为这些组件可以通过 service 方式创建,渲染 html 字符串的用例会比较多。

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@HyperLife1119 HyperLife1119 added 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: unreviewed PR: target-major labels Oct 9, 2024
@HyperLife1119 HyperLife1119 added this to the v19 milestone Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.91%. Comparing base (a48979f) to head (b28c291).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
components/date-picker/lib/date-table.component.ts 0.00% 2 Missing ⚠️
...mponents/date-picker/lib/decade-table.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8831      +/-   ##
==========================================
- Coverage   91.93%   91.91%   -0.03%     
==========================================
  Files         536      536              
  Lines       18455    18435      -20     
  Branches     2816     2816              
==========================================
- Hits        16967    16944      -23     
- Misses       1183     1185       +2     
- Partials      305      306       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119 HyperLife1119 marked this pull request as draft October 9, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: target-major PR: unreviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant