Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): wrap col within colgroup #8948

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

Laffery
Copy link
Collaborator

@Laffery Laffery commented Dec 20, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

nz-table-content 中的 col 没有用 colgroup 包起来,与服务端渲染出来的 html 不匹配,导致水合时报错 NG0502

Issue Number: close #8922

What is the new behavior?

nz-table-content 中的 col 使用 colgroup 包起来

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Dec 20, 2024

This preview will be available after the AzureCI is passed.

@Laffery Laffery changed the title fix(module:table): should col be wrapped within colgroup in ssr mode fix(module:table): wrap col with colgroup Dec 20, 2024
@Laffery Laffery changed the title fix(module:table): wrap col with colgroup fix(module:table): wrap col within colgroup Dec 20, 2024
Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 merged commit 0a73deb into NG-ZORRO:master Dec 20, 2024
7 of 8 checks passed
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.90%. Comparing base (5ffa099) to head (224a9ca).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8948      +/-   ##
==========================================
- Coverage   91.91%   91.90%   -0.02%     
==========================================
  Files         555      555              
  Lines       19708    19708              
  Branches     2942     2942              
==========================================
- Hits        18115    18113       -2     
- Misses       1267     1268       +1     
- Partials      326      327       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydration Missing Node NG0502 nz-table comoponent
2 participants