Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve interface of patch counts #214

Closed
rgknox opened this issue Apr 24, 2017 · 1 comment · Fixed by #862
Closed

improve interface of patch counts #214

rgknox opened this issue Apr 24, 2017 · 1 comment · Fixed by #862

Comments

@rgknox
Copy link
Contributor

rgknox commented Apr 24, 2017

The host land-model is solely in charge of how much space is available for patches. FATES does not really ask the HLM how much space is available, nor does it weigh in on this. We are just making sure that the maximum number of fates patches is smaller than the number the HLM comes up with. See EDTypesMod.F90: integer, parameter :: maxPatchesPerSite = 10

This situation could be improved by either leaving the decision completely up to the host model but at least performing a check to see if the desired number set in EDTypesMod is lower than the space allocated by the HLM, or better yet, by weighing in during clm_varpar when numpft is being decided, and when natpft_lb and natpft_ub are being calculated.

@rgknox
Copy link
Contributor Author

rgknox commented Aug 15, 2017

flagging this to be investigated/implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant