Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grass and woody biomass #277

Open
rosiealice opened this issue Sep 24, 2017 · 19 comments
Open

Grass and woody biomass #277

rosiealice opened this issue Sep 24, 2017 · 19 comments

Comments

@rosiealice
Copy link
Contributor

So, my first go at trying a grass-only simulation (for this workshop in Ft Collins) revealed that even with woody=0, there is still a non-zero non-trivial amount of woody biomass (didn't get to equilibrium, but >1kg/m2). Looking at the allocation code, there isn't actually a filter for woody. Instead , on line 597 of https://github.com/NGEET/fates/blob/master/biogeochem/EDPhysiologyMod.F90 , 'vs' is set to 1, if dbh>max_dbh, meaning that we currrently get fat woody grasses?

I think the solution is just to force:
if(EDPftvarcon_inst%woody(currentCohort%pft)==0)then
va = 1.0_r8; vs = 0.0_r8
endif

I tested this and it does reduce equilibrated bdead to <10g/m2 (the residual being from initialization I think). One thing that confused me is that my first fix, or setting EDPftvarcon_inst%allom_agb1 to 0 had barely any impact.

Does anyone object to this fix, or have an alternative grass allometry path we should take? @jkshuman @lmkueppers @ckoven @rgknox ?

@jkshuman
Copy link
Contributor

@rosiealice Please confirm the line you want to put this at, but, I think it is in the area of line 957. Seems reasonable to me. Nice find (though weird).

@rgknox
Copy link
Contributor

rgknox commented Sep 25, 2017

One thing I saw that might also need addressing: at the end of Growth_Derivatives(), in EDPhysiologyMod,F90, we set the dbh and height derivatives off of dbdeaddt (which is always 0 with the new logic). Now, I know grass doesn't have dbh, but I'm just curious how this will impact the model.
Still looking through this..

@rgknox
Copy link
Contributor

rgknox commented Sep 25, 2017

I guess the assumption is that grasses have a "ghost" dbh and wood density; and that allows leaf biomass, and that the size is constant? @rosiealice, are grasses supposed to grow in size following some allometry, or are they just expected to spread (or something else)?

@lmkueppers
Copy link

lmkueppers commented Sep 25, 2017 via email

@alistairrogers
Copy link

alistairrogers commented Sep 25, 2017 via email

@bpbond
Copy link

bpbond commented Sep 25, 2017

One go-to reference for this is the LTER book (co-edited by Alan Knapp) "Principles and Standards for Measuring Primary Production".

Nice find (though weird).

No kidding!

@lmkueppers
Copy link

lmkueppers commented Sep 25, 2017 via email

@rosiealice
Copy link
Contributor Author

rosiealice commented Sep 25, 2017

Ah, I think I have realized the error of my ways. There was a bug in my pft file script which caused clone_alloc + seed_alloc to be slightly <1, thus, some carbon was still going to structural while we were at the max_dbh (see #278). Testing the fix now. But yes, @rgknox and @lmkueppers , there is a 'ghost' dbh for grass which at the moment lives on the same allometry as the trees.

@bpbond, does Alan's book contain said descriptions of the allometric relations of grasses and how one might conceptualize the equivalent of 'dbh'? I don't have the book, and I'm probably not going to find it in the NCAR library. (We don't even have a New Phytologist subscription...) but it would be useful to know if there is a canonical grass expansion model out there.

@bpbond
Copy link

bpbond commented Sep 26, 2017

Hi @rosiealice -

I've just gone through the relevant part (chapter 3) of Fahey & Knapp and no, there's nothing about grass allometry; it's all about biomass harvest. I next turned to Karl Niklas' book and again, zip, zilch, nada on grasses.

Now I was interested :) Google Scholar doesn't yield a lot, but at least a couple publications:

  • Oliveras et al. (2013) fit high-altitude grass biomass regressions based on basal area, crown area, and maximum height. R2 values of 0.5-0.8, i.e. significantly lower than most single-stem woody plants.
  • Nafus et al. (2015) did something similar for semidesert rangeland grasses; height not significant, and better fits (R2 0.8-0.9) for diameter-based regression.

So, people don't do allometry with grasses very much. At all.

@rosiealice
Copy link
Contributor Author

Great. Thanks @bpbond! @lmkueppers has been communicating with the people organizing the workshop, who have ideas about leaf area-biomass relationships. Beginning to wonder whether we need a different concept for the grass populations. Maybe we should ignore 'n' and 'dbh' and just use biomass/lai/areal extent relationships instead?

@mdietze
Copy link
Collaborator

mdietze commented Sep 26, 2017

We encountered a similar problem when my lab started using ED2 to do biofuel work. Tying the allometry to DBH (or 'virtual DBH') doesn't make sense so we switched to height as the basis and were able to calibrate relationships in the field pretty easily. Yes, the R2 are lower

@alistairrogers
Copy link

alistairrogers commented Sep 26, 2017 via email

@bpbond
Copy link

bpbond commented Sep 26, 2017

@alistairrogers - no, I was just looking for grasses. Could do so.

Based on those two publications and @mdietze 's experience, it does seem like height would be a promising general biomass predictor. I'd be interested to hear a grassland specialist's opinion on this too, though.

@lmkueppers
Copy link

lmkueppers commented Sep 26, 2017 via email

@ckoven
Copy link
Contributor

ckoven commented Sep 26, 2017

isnt the bigger issue the crown area allometry and how to adapt ppa to grasses? or are we assumjng stem diamater equals crown diameter?

@lmkueppers
Copy link

lmkueppers commented Sep 26, 2017 via email

@aswann
Copy link
Collaborator

aswann commented Sep 26, 2017 via email

@rosiealice
Copy link
Contributor Author

This is still open for so,e reason. Do we still have woody biomass in grasses or can we throw this one on the closed pile?

@ckoven
Copy link
Contributor

ckoven commented Dec 13, 2022

So I think there are two separate issues here. One was that grasses were producing coarse (woody) fuels, and the other is the live biomass allocation (which I read this issue to be mostly talking about). #891 fixed the first issue but not the second. If the allometry parameters are such that dead stem carbon is nonzero, then grasses will follow that. So I would suggest we keep this open until we have a PR that addresses actual measured grass allometry parameters (which @XiulinGao is working on) and close it once that is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants