Move calculation of frac_lai to outside the hlm_numSWb loop

[adrifoster]

In looking at the radiation code, I noticed that we are potentially unnecessarily recalculating frac_lai and frac_sai for visible and NIR bands (

fates/biogeophys/EDSurfaceAlbedoMod.F90

Line 321 in 7edf030

if (currentPatch%canopy_area_profile(L,ft,iv) > 0._r8)then

):

      do  iv = 1, currentPatch%nrad(L,ft)
         if (currentPatch%canopy_area_profile(L,ft,iv) > 0._r8)then
            currentPatch%canopy_mask(L,ft) = 1
            ! layer level reflectance qualities
            do ib = 1,hlm_numSWb !vis, nir
               if(currentPatch%elai_profile(L,ft,iv)+ currentPatch%esai_profile(L,ft,iv).gt.0.0_r8) then
                  frac_lai = currentPatch%elai_profile(L,ft,iv)/&
                       (currentPatch%elai_profile(L,ft,iv)+ currentPatch%esai_profile(L,ft,iv))
               else
                  frac_lai = 1.0_r8
               endif
               !frac_lai = 1.0_r8 ! make the same as previous codebase, in theory.
               frac_sai = 1.0_r8 - frac_lai

These calculations occur inside the do ib = 1, hlm_numSWb loop, but I don't think they are actually affected by the ib value. Should we move this to just before the do ib... loop? It may save us a modicum of computation time, and helps with code understandability.

Alternatively, I may be wrong! I conferred with @glemieux, but if others could chime in that would be helpful!

[rgknox]

we checked in on this in the software meeting, and there was agreement with @adrifoster that her plan to improve the algorithm is solid

[adrifoster]

I think we can close this now!