move frac_lai and frac_sai calculation outside do ib=1,hlm_numSWb loop

[adrifoster]

Description:

Fixes a minor issue where the calculation of frac_lai and frac_sai was calculated twice unnecessarily inside the do ib = 1,hlm_numSWb loop. I moved the calculation outside of the loop and tested to make sure updates were bit for bit.

This will save us (a small amount) of run time and make the code more accurate/readable.

This resolves issue #843.

Collaborators:

@glemieux

Expectation of Answer Changes:

None. I ran a simple fates test suite and everything was bit-for-bit.

Checklist:

• My change requires a change to the documentation.
• I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
• I have read the CONTRIBUTING document.
• FATES PASS/FAIL regression tests were run
• If answers were expected to change, evaluation was performed and provided

Test Results:

I ran a fates test suite on Cheyenne against fates-sci.1.55.4_api.22.1.0-ctsm5.1.dev084, however CTSM is currently on dev085 so there were some expected NLCOMP diffs from the update to dev085. I will run the required tests again when it is time to push this through.

CTSM (or) E3SM (specify which) test hash-tag:

ctsm5.1.dev085

CTSM (or) E3SM (specify which) baseline hash-tag:

ctsm5.1.dev084

FATES baseline hash-tag:

fates-sci.1.55.4_api.22.1.0

Test Output:

Many NLCOMP diffs from the difference between dev085 and dev084 but this was expected. Once we update our baselines I will test again.

Tests are on Cheyenne: /glade/scratch/afoster/tests_0317-152648ch

[glemieux]

Thanks @adrifoster. Would you mind adding the link to the test results directory in the comments so we can do a double check?

[adrifoster]

Tests are on Cheyenne: /glade/scratch/afoster/tests_0317-152648ch