Landuse data tool #1107
Closed
Landuse data tool #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix "too much canopy" error for SP mode runs This corrects a typo in which the wrong patch was being sourced for patch area correction. It also includes a correction to history long names.
This adds the renormalization and its test as well as a check on the data type conversion and lat/lon update to the CLM5 data
All tests pass
This is largely complete. That said, it could use having the previous luh2 dataset functions refactored and rolled into this one, including adding new unit tests for the old luh2 code.
glemieux
added
PR status: Not Ready
Hydraulic failure mortality turned off for frozen soils Hydraulic failure mortality is turned off when any soil layer is below -2 degrees C. This should prevent high mortality of vegetation at high latitudes.
This also continues to simplify the luh2mod module by removing unnecessary functions
This update avoids having to run multiple calls to the luh2 command to generate a full combined luh2 data file for fates usage. It instead loops through all the files and merges them together on the fly.
also add a unit test for this function
glemieux
removed
the
PR status: Not Ready
This needs to be rewritten as well in a future commit
|
Closing this out as I've moved it to https://github.com/NGEET/tools-fates-landusedata |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool chain for creating the landuse x pft static input and the luh2 timesseries datasets
Description:
This PR creates a top-level
landusedatapython package to the fates tool directory. This tool has been developed with a project package structure. It includes unit tests for the tool functions using thepytestpackage. The tool includes subcommands to generate either the luh2 timeseries dataset or landuse x pft static data map. It accomplishes this by refactoring the luh2 data tool introduced in #1032 into the package and adding new functionality to generate the landuse x pft map.Collaborators:
@ckoven
Expectation of Answer Changes:
None as this is new tooling
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: