Fix water balance error for grass when use FATES-Hydro #910
Conversation
| else | ||
| v_leaf_donate(1:n_hypool_leaf) = ccohort_hydr%v_ag(1:n_hypool_leaf) * l2sap_vol_donate_frac | ||
| ccohort_hydr%v_ag(1:n_hypool_leaf) = ccohort_hydr%v_ag(1:n_hypool_leaf) - v_leaf_donate(1:n_hypool_leaf) | ||
| ccohort_hydr%v_ag(n_hypool_leaf+1:n_hypool_ag) = (v_sapwood + sum(v_leaf_donate(1:n_hypool_leaf))) / n_hypool_stem |
| @@ -29,7 +29,7 @@ module FatesHydraulicsMemMod | |||
| integer, parameter, public :: n_hypool_stem = 1 | |||
| integer, parameter, public :: n_hypool_troot = 1 ! CANNOT BE CHANGED | |||
| integer, parameter, public :: n_hypool_aroot = 1 ! THIS IS "PER-SOIL-LAYER" | |||
| integer, parameter, public :: nshell = 5 | |||
| integer, parameter, public :: nshell = 1 | |||
There was a problem hiding this comment.
I like this change too, sensitivity analysis I've done have shown that we get small/subtle differences when we use multiple versus a single shell.
There was a problem hiding this comment.
checked in via email with @xuchongang and @bchristo and they both blessed this change as well
|
Regression testing on cheyenne underway. |
|
Regression testing on cheyenne returns B4B results for all non-hydro tests as expected. Both hydro tests DIFFs look reasonable given that the initial differences are in rootuptake output variables. Issue #701 appears to have been corrected here, at least temporarily, in that the exact restart hydro test is passing now Folder location: One note: for some reason |
This looks like its a tempermental issue and not necessarily fixed by this PR. In re-running the previous baseline, this issue wasn't present suggesting that there is something else going on to cause #701. |
This baseline has been regenerated and tested against the old version (which I've saved with the suffix |
Description:
Changed the FatesPlantHydraulicsMod.F90, when the PFT is grass, pool the storage of leaf and stem
Collaborators:
Expectation of Answer Changes:
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: