Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New allometry option for storage #959

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Conversation

mpaiao
Copy link
Contributor

@mpaiao mpaiao commented Dec 5, 2022

New option for storage allometry.

Description:

This is a minor an optional revision of the storage allometry. If fates_allom_stmode=2, then storage allometry will be proportional to the untrimmed leaf biomass, as a way to make the potential non-structural carbon accumulation to be scaled with the maximum leaf biomass given the PFT size.

Collaborators:

Expectation of Answer Changes:

Simulations using the default fates_allom_stmode=1 should not generate different answers.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

Option 2 now scales storage with the untrimmed leaf biomass, which allows higher
storage when canopy is trimmed.
Copy link
Contributor

@ckoven ckoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpaiao this looks great! I had forgotten that we had even put in a switch for multiple storage allometries, so using it as you do here is great. Curious how this changes model behavior for the cases where you use allom_stmode=2?

@glemieux glemieux self-assigned this Jan 25, 2023
@glemieux
Copy link
Contributor

I confirmed that I could build and run a simple single site case after turning on the new stmode in the parameter file. Regression tests are currently running on cheyenne.

@glemieux
Copy link
Contributor

Regression testing on Cheyenne is complete. All expected tests are b4b against fates-sci.1.61.0_api.25.0.0-ctsm5.1.dev115.

@glemieux glemieux merged commit a0028dd into NGEET:main Jan 30, 2023
@mpaiao mpaiao deleted the mpaiao-pr-allom-stmode branch December 5, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants