Update code to support China instance of the SB platform

[aleksandarbaburski]

Hi Ryan, we updated the code to support SB China Platform:

• In the sevenbridges_platform.py, we added two child classes (SevenBridgesPlatform_US and SevenBridgesPlatform_CN) that inherit the functionality from SevenBridgesPlatform class, but have unique detect method and some platform configuration settings. Note: the detect method actually tries to connect to the US or CN platform because there is no other way to detect what platform the launcher is running on.
• In regard to that, we updated SUPPORTED_PLATFORMS dict in init.py to include US and CN SB platforms.
• platform_config.py file was added. It contains sb_credentials and sb_execution_settings, so those things are not hardcoded in the sevenbridges_platform.py

If you have any questions please let us know.

[golharam]

The platform_config.py settings are specific to SevenBridges. Can these be put inside the sevenbridges_platform.py file?

[aleksandarbaburski]

Yes, done!

[golharam]

This is a public repo....hard-coded urls should not be here. I think this is better passed in from the launcher/code using this repo.

[aleksandarbaburski]

Hi @golharam, yes, I see.
So, we should move credentials (api endpoint, token, profile) from this repo to launcher specific config files on github.com/bmsgh/ repos (RNA, 10X, WES...) and then, in launcher.py, provide those credentials as an input when run PAML code.
Is that correct?

[golharam]

yes, I thinks that the best thing to do.

[golharam]

credentials, tokens, etc should be provided from the launcher.

[aleksandarbaburski]

Hi @golharam,
I moved api endpoint, token and profile from this repo, meaning that those need be provided now as input to detect and connect methods when we call them. If we take RNA launcher.py for example those lines are going to look like this:
args.platform = PlatformFactory().detect_platform(credentials)
and
platform.connect(credentials)
where credentials is a dict (that will be defined in launcher config) with a following structure:

credentials = {
            'US': {
                'api_endpoint': '',
                'token': '',
                'profile': ''
            },
            'CN': {
                'api_endpoint': '',
                'token': '',
                'profile': ''
            }
        }

Let me know what you think.

[aleksandarbaburski]

Hi @golharam, did you have chance to review last changes we made? Credentials are moved from this repo.

[aleksandarbaburski]

Hi @golharam,
I removed use_elastic_disk option from default execution_settings for china platform (as mentioned on the meeting).

Please review the changes and let me know (once you decide) whether we are going to store credentials here or on individual launcher repos (RNA, WES, etc). Based on that I'll make some adjustments to the code and finalise the #16 effort.