Optionally prefer system wide pybind11 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux distributions typically prefer system provided libraries, so optionally use it when found. (This also allows to use the github provided tarball, which omits the pybind11 submodule). Fix the PYBIND_INCLUDE_DIR usage: - remove misleading find_path invocation, which may point to the system wide pybind11 - use pybind11_INCLUDE_DIR which is provided by both find_package(pybind11) and bundled pybind11/CMakeLists.txt - pybind11_INCLUDE_DIR is used by pybind11_add_module, use it also for ngcore (core/register_archive.hpp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux distributions typically prefer system provided libraries, so
optionally use it when found.
(This also allows to use the github provided tarball, which omits the
pybind11 submodule).
Fix the PYBIND_INCLUDE_DIR usage:
wide pybind11
and bundled pybind11/CMakeLists.txt
ngcore (core/register_archive.hpp)