Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links are not re-generated when external address changes #48

Closed
TechSupportJosh opened this issue Jul 15, 2022 · 2 comments
Closed

Links are not re-generated when external address changes #48

TechSupportJosh opened this issue Jul 15, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@TechSupportJosh
Copy link
Contributor

TechSupportJosh commented Jul 15, 2022

As the title says, when links are created, they embed the current external address into the binary. However, if you restart the server and change the external address (common on OSCP, CTFs, etc. where you may have a different IP/port for each service), they keep the previous embedded address, rather than it being rebuilt with the new address.

If this is intended, it'd be nice for the links to display what address they have embedded within them inside the server menu.

@NHAS NHAS added the bug Something isn't working label Jul 15, 2022
@NHAS NHAS self-assigned this Jul 15, 2022
@NHAS
Copy link
Owner

NHAS commented Jul 15, 2022

Yep! This isnt intended (although it isnt designed to change as I didnt think of it)

I'll fix this

NHAS added a commit that referenced this issue Jul 16, 2022
@NHAS
Copy link
Owner

NHAS commented Jul 16, 2022

With further consideration, Im not going to regenerate the binaries on startup, as people may want to generate binaries for different external hosts on purpose, and it becomes a bit jank to cope with that.

So I've made the cache and link -l command print the binaries homeserver/callback.

@NHAS NHAS closed this as completed Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants