Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA for Admin portal #77

Open
bluecraank opened this issue Nov 23, 2023 · 4 comments
Open

2FA for Admin portal #77

bluecraank opened this issue Nov 23, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request needs testing (on unstable) If the feature exists, but isnt yet released

Comments

@bluecraank
Copy link
Contributor

There should be a option to enable 2fa for admin portal

@NHAS
Copy link
Owner

NHAS commented Nov 23, 2023

You're definitely not wrong. Just dont really want people exposing the admin portal anywhere regardless, I tend to use it over an SSH forward

@NHAS NHAS added the enhancement New feature or request label Nov 23, 2023
@JSmith-Aura
Copy link
Contributor

I think what Im going to do for this is just use an OIDC provider to log in instead of implementing 2fa myself. It makes it a bit easier on me.

@NHAS NHAS self-assigned this Sep 1, 2024
@NHAS NHAS added the needs testing (on unstable) If the feature exists, but isnt yet released label Sep 1, 2024
@NHAS
Copy link
Owner

NHAS commented Sep 1, 2024

I have now added an oidc provider to the admin page which can be configured via the management ui json setting:

	ManagementUI struct {
		usualWeb
		Enabled bool
		Debug   bool

		OIDC struct {
			AdminDomainURL string

			IssuerURL    string
			ClientSecret string
			ClientID     string
			Enabled      bool
		} `json:",omitempty"`
	} `json:",omitempty"`

Still needs so work in terms of, adding the oidc admin to the admin users list. And potentially if people want, restrictions.

@NHAS
Copy link
Owner

NHAS commented Sep 1, 2024

Sweet all that minus the restrictions are done. If people want this to be part of a groups claim or whatnot add it to this issue. Otherwise this feature is now completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs testing (on unstable) If the feature exists, but isnt yet released
Projects
None yet
Development

No branches or pull requests

3 participants