Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DW-3639] remove legacy google analytics #2669

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GeoffreyHayward
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented May 8, 2024

Test Results
Failures:%0A%0A1) Scenario: Check video banner video # features/macros/banner.feature:35%0A ✔ Given I navigate to the "banner" macro test page # src/step-definitions/site-steps.ts:41%0A ✔ When "video banner" YouTube embed has loaded # src/step-definitions/youtube-embeds.ts:10%0A ✔ And I click target "video" element # src/step-definitions/site-steps.ts:49%0A ✖ Then "video banner" YouTube embed should start playing # src/step-definitions/youtube-embeds.ts:45%0A AssertionError%0A + expected - actual%0A%0A -false%0A +true%0A%0A at CustomWorld. (/home/runner/work/hippo/hippo/acceptance-tests/src/test/node/src/step-definitions/youtube-embeds.ts:64:31)%0A ✔ After # src/setup/hooks/screenshot-on-failure.ts:4%0A Attachment (image/png)%0A%0A22 scenarios (1 failed, 21 passed)%0A78 steps (1 failed, 77 passed)%0A3m34.055s (executing steps: 3m33.908s)

Copy link

github-actions bot commented May 8, 2024

Test Results
22 scenarios (22 passed)%0A78 steps (78 passed)%0A3m27.055s (executing steps: 3m26.909s)

@GeoffreyHayward GeoffreyHayward force-pushed the DW-3639-remove-legacy-google-analytics branch from 51babe4 to 445782c Compare May 9, 2024 09:57
@GeoffreyHayward GeoffreyHayward force-pushed the DW-3639-remove-legacy-google-analytics branch from 445782c to 5f76f53 Compare May 9, 2024 10:01
Copy link

github-actions bot commented May 9, 2024

JS Lint has failed. Run make lint-frontend locally to find what needs fixing.

Copy link

github-actions bot commented May 9, 2024

Test Results
22 scenarios (22 passed)%0A78 steps (78 passed)%0A3m24.524s (executing steps: 3m24.410s)

Copy link

github-actions bot commented May 9, 2024

Test Results
22 scenarios (22 passed)%0A78 steps (78 passed)%0A3m24.926s (executing steps: 3m24.810s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants