Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMP-3236] Added footer banner in API and service catalogue #2727

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[AMP-3236] Added footer banner in API and service catalogue #2727

wants to merge 3 commits into from

Conversation

vinodkumarnarayanan1
Copy link
Contributor

Added footer banner in API and Service catalogue:

API Catalogue:
image

Service Catalogue:
image

@vinodkumarnarayanan1 vinodkumarnarayanan1 requested a review from a team as a code owner January 24, 2025 17:21
@github-actions GitHub Actions
Copy link

Test Results
22 scenarios (22 passed)%0A78 steps (78 passed)%0A3m27.878s (executing steps: 3m27.771s)

@github-actions GitHub Actions
Copy link

Test Results
22 scenarios (22 passed)%0A78 steps (78 passed)%0A3m25.052s (executing steps: 3m24.935s)

GeoffreyHayward
GeoffreyHayward reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@GeoffreyHayward GeoffreyHayward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to do the trick. But a note on content/documents/corporate-website/banners.yaml this will not put the content onto any of the servers. So you will have to create this content or import.

Please tidy the IDs (see comment).

.../src/main/resources/hcm-config/hst/configurations/common/workspace/workspace/containers.yaml Outdated Show resolved Hide resolved
@vinodkumarnarayanan1
Copy link
Contributor Author

This seems to do the trick. But a note on content/documents/corporate-website/banners.yaml this will not put the content onto any of the servers. So you will have to create this content or import.

Please tidy the IDs (see comment).

Thank you letting me know this Geoff

@github-actions GitHub Actions
Copy link

Test Results
22 scenarios (22 passed)%0A78 steps (78 passed)%0A3m23.648s (executing steps: 3m23.534s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyHayward GeoffreyHayward GeoffreyHayward left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinodkumarnarayanan1 @GeoffreyHayward