Skip to content

Conversation

@DWolfsNHS
Copy link
Collaborator

  • Replace manual Docker pull and tag commands with a Makefile target
  • Update image name usage to utilize dynamic repository and tag variables
  • Simplify the build process for better maintainability

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

- Replace manual Docker pull and tag commands with a Makefile target
- Update image name usage to utilize dynamic repository and tag variables
- Simplify the build process for better maintainability
- Introduce HARDCODED_API_KEY for API schema validation tests
- Mark key with a FIXME to indicate future removal for secret management
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

- Removed redundant test directory from exclusions
- Streamlined exclusion patterns for clarity
…nment setup action

- Set Python version as an environment variable
- Modify Docker image build step to utilize the python setup action
- Refactor setup step to use environment variable for Python version
- Ensure Docker image build step follows the new setup
- Set PYTHON_VERSION environment variable for Docker image build
Base automatically changed from GPCAPIM-166helloWorld to main January 9, 2026 14:35
- Remove trailing hyphens from the target group name
- Change target group name to use branch name instead of effective host name
- Ensure name adheres to regex replacement for trailing hyphens
- Replace regex_replace with replace for cleaner name formatting
- Ensure target group name adheres to length and character constraints
…tecture

- Trim trailing hyphens from the target group name
- Change ECS task definition CPU architecture from ARM64 to X86_64
- Change default container port from 80 to 5000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant