generated from NHSDigital/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
using built container image #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DWolfsNHS
wants to merge
12
commits into
main
Choose a base branch
from
feature/GPCAPIM-166_built_image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace manual Docker pull and tag commands with a Makefile target - Update image name usage to utilize dynamic repository and tag variables - Simplify the build process for better maintainability
- Introduce HARDCODED_API_KEY for API schema validation tests - Mark key with a FIXME to indicate future removal for secret management
|
- Removed redundant test directory from exclusions - Streamlined exclusion patterns for clarity
…nment setup action - Set Python version as an environment variable - Modify Docker image build step to utilize the python setup action
- Refactor setup step to use environment variable for Python version - Ensure Docker image build step follows the new setup
- Set PYTHON_VERSION environment variable for Docker image build
- Remove trailing hyphens from the target group name
- Change target group name to use branch name instead of effective host name - Ensure name adheres to regex replacement for trailing hyphens
- Replace regex_replace with replace for cleaner name formatting - Ensure target group name adheres to length and character constraints
…tecture - Trim trailing hyphens from the target group name - Change ECS task definition CPU architecture from ARM64 to X86_64
- Change default container port from 80 to 5000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.