Skip to content

New: [AEA-5426] - Add API Gateway as VPC Endpoint #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connoravo-nhs wants to merge 12 commits into
base: main
Choose a base branch
from
Open

New: [AEA-5426] - Add API Gateway as VPC Endpoint #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7fe6ed1
New: [AEA-5426] - Add API Gateway as VPC Endpoint
connoravo-nhs Jun 12, 2025
bbd2234
Allow for private interface endpoint
connoravo-nhs Jun 12, 2025
5d2fec2
Add export for VPC Endpoint ID
connoravo-nhs Jun 12, 2025
ff191e8
Remove potentially unnecessary export
connoravo-nhs Jun 12, 2025
0c137ce
Deploy change temporarily
connoravo-nhs Jun 12, 2025
08361c9
Merge branch 'main' into AEA-5426
connoravo-nhs Jun 12, 2025
607ecc0
Suppress permissions issue
connoravo-nhs Jun 12, 2025
e4a6f01
Add required nag suppressions
connoravo-nhs Jun 12, 2025
ff249d4
Merge branch 'AEA-5426' of github.com-nhs:NHSDigital/eps-vpc-resource…
connoravo-nhs Jun 12, 2025
b459e4e
Revert deploy change
connoravo-nhs Jun 12, 2025
190663b
Dev container, support mac users
connoravo-nhs Jun 13, 2025
27a85a6
Revert "Dev container, support mac users"
connoravo-nhs Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 118 additions & 0 deletions packages/cdk/nagSuppressions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,124 @@ export const nagSuppressions = (stack: Stack) => {
]
)

safeAddNagSuppression(
stack,
"/VpcResourcesStack/apiGatewayEndpoint-tags/CustomResourcePolicy/Resource",
[
{
id: "AwsSolutions-IAM5",
reason: "Suppress error for wildcard permissions. This is fine here"
}
]
)

safeAddNagSuppression(
stack,
"/VpcResourcesStack/vpc/ECRDockerEndpoint/SecurityGroup/Resource",
[
{
id: "AwsSolutions-EC23",
reason: "Suppress error for lack of CDK validation of supplied open CIDR being that of VPC. This is fine here. \
See https://github.com/cdklabs/cdk-nag/issues/817"
}
]
)

safeAddNagSuppression(
stack,
"/VpcResourcesStack/vpc/ECREndpoint/SecurityGroup/Resource",
[
{
id: "AwsSolutions-EC23",
reason: "Suppress error for lack of CDK validation of supplied open CIDR being that of VPC. This is fine here. \
See https://github.com/cdklabs/cdk-nag/issues/817"
}
]
)

safeAddNagSuppression(
stack,
"/VpcResourcesStack/vpc/SecretManagerEndpoint/SecurityGroup/Resource",
[
{
id: "AwsSolutions-EC23",
reason: "Suppress error for lack of CDK validation of supplied open CIDR being that of VPC. This is fine here. \
See https://github.com/cdklabs/cdk-nag/issues/817"
}
]
)

safeAddNagSuppression(
stack,
"/VpcResourcesStack/vpc/CloudWatchEndpoint/SecurityGroup/Resource",
[
{
id: "AwsSolutions-EC23",
reason: "Suppress error for lack of CDK validation of supplied open CIDR being that of VPC. This is fine here. \
See https://github.com/cdklabs/cdk-nag/issues/817"
}
]
)

safeAddNagSuppression(
stack,
"/VpcResourcesStack/vpc/CloudWatchLogsEndpoint/SecurityGroup/Resource",
[
{
id: "AwsSolutions-EC23",
reason: "Suppress error for lack of CDK validation of supplied open CIDR being that of VPC. This is fine here. \
See https://github.com/cdklabs/cdk-nag/issues/817"
}
]
)

safeAddNagSuppression(
stack,
"/VpcResourcesStack/vpc/CloudWatchEventsEndpoint/SecurityGroup/Resource",
[
{
id: "AwsSolutions-EC23",
reason: "Suppress error for lack of CDK validation of supplied open CIDR being that of VPC. This is fine here. \
See https://github.com/cdklabs/cdk-nag/issues/817"
}
]
)

safeAddNagSuppression(
stack,
"/VpcResourcesStack/vpc/SSMEndpoint/SecurityGroup/Resource",
[
{
id: "AwsSolutions-EC23",
reason: "Suppress error for lack of CDK validation of supplied open CIDR being that of VPC. This is fine here. \
See https://github.com/cdklabs/cdk-nag/issues/817"
}
]
)

safeAddNagSuppression(
stack,
"/VpcResourcesStack/vpc/LambdaEndpoint/SecurityGroup/Resource",
[
{
id: "AwsSolutions-EC23",
reason: "Suppress error for lack of CDK validation of supplied open CIDR being that of VPC. This is fine here. \
See https://github.com/cdklabs/cdk-nag/issues/817"
}
]
)

safeAddNagSuppression(
stack,
"/VpcResourcesStack/vpc/apiGatewayEndpoint/SecurityGroup/Resource",
[
{
id: "AwsSolutions-EC23",
reason: "Suppress error for lack of CDK validation of supplied open CIDR being that of VPC. This is fine here. \
See https://github.com/cdklabs/cdk-nag/issues/817"
}
]
)
}

const safeAddNagSuppression = (stack: Stack, path: string, suppressions: Array<NagPackSuppression>) => {
Expand Down
11 changes: 11 additions & 0 deletions packages/cdk/stacks/VpcResourcesStack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ export class VpcResourcesStack extends Stack {
this.addInterfaceEndpoint("CloudWatchEventsEndpoint", InterfaceVpcEndpointAwsService.EVENTBRIDGE)
this.addInterfaceEndpoint("SSMEndpoint", InterfaceVpcEndpointAwsService.SSM)
this.addInterfaceEndpoint("LambdaEndpoint", InterfaceVpcEndpointAwsService.LAMBDA)
this.addPrivateInterfaceEndpoint("apiGatewayEndpoint", InterfaceVpcEndpointAwsService.APIGATEWAY)
this.addGatewayEndpoint("S3Endpoint", InterfaceVpcEndpointAwsService.S3)

//Outputs
Expand Down Expand Up @@ -161,6 +162,16 @@ export class VpcResourcesStack extends Stack {
endpoint.connections.allowFrom(Peer.ipv4(this.vpc.vpcCidrBlock), endpoint.connections.defaultPort!)
}

private addPrivateInterfaceEndpoint(name: string, awsService: InterfaceVpcEndpointAwsService): void {
const endpoint: InterfaceVpcEndpoint = this.vpc.addInterfaceEndpoint(name, {
service: awsService
})
this.addEndpointTag(name, endpoint)

endpoint.connections.allowFrom(Peer.ipv4(this.vpc.privateSubnets[0].ipv4CidrBlock),
endpoint.connections.defaultPort!)
}

private addGatewayEndpoint(name: string, awsService: InterfaceVpcEndpointAwsService): void {
const endpoint: GatewayVpcEndpoint = this.vpc.addGatewayEndpoint(name, {
service: awsService
Expand Down