Breaking: [AEA-0000] - build dev container #23
Conversation
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
SonarCloud found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
anthony-nhs
changed the title
.github/workflows/release.yml
Outdated
|
|
||
| tag_latest_nhsd_git_secrets: | ||
| needs: [quality_checks, get_commit_id, tag_release] | ||
| uses: ./.github/workflows/tag_latest_dev_container.yml |
There was a problem hiding this comment.
This filename is confusing as this job isn't a dev container, maybe
| uses: ./.github/workflows/tag_latest_dev_container.yml | |
| uses: ./.github/workflows/tag_latest_multi-arch_ecr_image.yml |
There was a problem hiding this comment.
changed to tag_latest_container_images
.github/workflows/release.yml
Outdated
| needs: [quality_checks, get_commit_id, tag_release] | ||
| uses: ./.github/workflows/tag_latest_dev_container.yml | ||
| with: | ||
| dev_container_ecr: dev-container-git-secrets |
There was a problem hiding this comment.
as above, maybe
| dev_container_ecr: dev-container-git-secrets | |
| ecr_repo_name: git-secrets |
There was a problem hiding this comment.
changed input to ecr_name and changed name of ecr used for git secrets
.github/workflows/release.yml
Outdated
| uses: ./.github/workflows/tag_latest_dev_container.yml | ||
| with: | ||
| dev_container_ecr: dev-container-git-secrets | ||
| dev_container_image_tag: release-${{ needs.get_commit_id.outputs.sha_short }} |
There was a problem hiding this comment.
as above, maybe
| dev_container_image_tag: release-${{ needs.get_commit_id.outputs.sha_short }} | |
| ecr_image_tag: release-${{ needs.get_commit_id.outputs.sha_short }} |
There was a problem hiding this comment.
changed to container_image_tag
| type: string | ||
| description: "The tag to download check_ecr_image_scan_results.sh script." | ||
| required: false | ||
| default: "dev_container_build" |
There was a problem hiding this comment.
I guess we should be changing this before merge
There was a problem hiding this comment.
yes, or do another pull request after changing it to main
| type: string | ||
| description: "The tag to use for the dev container image." | ||
| required: true | ||
| check_ecr_image_scan_results_script_tag: |
| "postAttachCommand": "docker build -f https://raw.githubusercontent.com/NHSDigital/eps-workflow-quality-checks/refs/tags/v4.0.2/dockerfiles/nhsd-git-secrets.dockerfile -t git-secrets . && pre-commit install --install-hooks -f", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/docker-outside-of-docker:1": { | ||
| "version": "latest", | ||
| "moby": "true", | ||
| "installDockerBuildx": "true" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
question: do we want to update the devcontainer.json in this pr to include the tags url instead of the current one that's just pointing to the one that is local?
There was a problem hiding this comment.
I want to change how we get the git-secrets - will do that in another pr
|
3 participants
Summary
Details