NDRS view coding #45
Open
NDRS view coding #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NDRS view coding from NECS
|
@KLB-Tsang please see below:
|
BillWoodNHS
requested changes
Oct 14, 2025
There was a problem hiding this comment.
- please add a readme.md file to the root "NDRS" folder that will explain what the dataset is. You can borrow whole paragraphs from the NHS Digital pages on the subject (see https://digital.nhs.uk/services/national-disease-registration-service)
- please place the SQL definition files into a subfolder
NDRS/source_objects/tables/MSSQL/- this will indicate that the table definitions are from the source/supplier and are an MSSQL file (rather than a snowflake SQL file). Views, if they exist, can be added to a similar subfolderNDRS/source_objects/views/MSSQL/
|
I have made the following amendments - please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NDRS view coding from NECS