Feature/company profile

[toni-santos]

Closes #9

[BrunoRosendo]

Is this ready for review?

[toni-santos]

I think so, I'm not sure why the audit is failing, but the goals of the issue are all met!

[BrunoRosendo]

This is already looking good, nice job!

Something related to this but for another issue:
@imnotteixeira @DoStini Will the company profile also have infinite scrolling or will the offers just be limited? We already have an endpoint to return all the company offer, we could adapt that to return with a offset/limit (or using the same strategy as in the future new search). What do you think?

[imnotteixeira]

This is already looking good, nice job!

Something related to this but for another issue: @imnotteixeira @DoStini Will the company profile also have infinite scrolling or will the offers just be limited? We already have an endpoint to return all the company offer, we could adapt that to return with a offset/limit (or using the same strategy as in the future new search). What do you think?

Let's not insist on the offset/limit strategy, especially since we are implementing #129 with cursors.

I'd say we should not have infinite scrolling, but rather an explicit "load more" button which the user would click, but for the backend it would work the same way so it doesn't matter.

[toni-santos]

I believe the changes that were discussed previously have all been implemented, taking into account the restrictions and difficulties imposed by how the mongoose queries are currently working. Please alert me to any changes that should be made!

[Naapperas]

Also, be aware of the file conflicts due to this branch not being "up-to-date"

[BrunoRosendo]

The assignee will change

[ttoino]

The tests should now align with the implementation goals, right now the following restrictions are in place:

• When the company is disabled, blocked or has not finished registration, the same error as when the company does not exist is returned;
• When the company is disabled and the user is the owner, admin or god it succeeds;
• When the company is blocked and the user is the owner an error is returned;
• When the company is blocked and the user is an admin or god it succeeds;
• When the company has not finished registration and the user is the owner, admin or god an error is returned (not sure about this one).

If any of these don't make sense please let me know.

[Naapperas]

The tests should now align with the implementation goals, right now the following restrictions are in place:

* When the company is disabled, blocked or has not finished registration, the same error as when the company does not exist is returned;

* When the company is disabled and the user is the owner, admin or god it succeeds;

* When the company is blocked and the user is the owner an error is returned;

* When the company is blocked and the user is an admin or god it succeeds;

* When the company has not finished registration and the user is the owner, admin or god an error is returned (not sure about this one).

If any of these don't make sense please let me know.

I think that not having finnished its registratio should not be a restriction on company fetching. What do you think @BrunoRosendo @DoStini ?

[BrunoRosendo]

The tests should now align with the implementation goals, right now the following restrictions are in place:

* When the company is disabled, blocked or has not finished registration, the same error as when the company does not exist is returned;

* When the company is disabled and the user is the owner, admin or god it succeeds;

* When the company is blocked and the user is the owner an error is returned;

* When the company is blocked and the user is an admin or god it succeeds;

* When the company has not finished registration and the user is the owner, admin or god an error is returned (not sure about this one).

If any of these don't make sense please let me know.

I think that not having finnished its registratio should not be a restriction on company fetching. What do you think @BrunoRosendo @DoStini ?

What information would we have in that case? Not sure if it's useful for a company profile but, either way, we should have the same restriction as in the "get all companies" endpoint

[DoStini]

Im my opinion, if a company didnt finish their registration, is like of they do not exist in the platform at all. So I think we should 404 Not Found for hidden companies and not finished

[Naapperas]

Besides the comments I made, this looks good to me. Just be careful to rebase this branch with develop.

[ttoino]

I decided to leave the implementation as is and created a new issue to deal with the inconsistent http statuses (#282).

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18 🎉

Comparison is base (fd829d7) 90.33% compared to head (1b4ac39) 90.51%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #207      +/-   ##
===========================================
+ Coverage    90.33%   90.51%   +0.18%     
===========================================
  Files           54       54              
  Lines         1417     1444      +27     
  Branches       232      242      +10     
===========================================
+ Hits          1280     1307      +27     
  Misses         132      132              
  Partials         5        5              

Impacted Files	Coverage Δ
src/api/middleware/company.js	95.38% <100.00%> (+1.63%)	⬆️
src/api/middleware/validators/company.js	100.00% <100.00%> (ø)
src/api/routes/company.js	88.23% <100.00%> (+0.89%)	⬆️
src/api/routes/offer.js	77.63% <100.00%> (ø)
src/services/offer.js	99.16% <100.00%> (+0.02%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Naapperas]

Other than the pointed out code, this looks good to me.

[render]

Your Render PR Server URL is https://nijobs-backend-pr-207.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cg3lisu4dad6b95gv0k0.