Refactor Company Application Status #349
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the virtual state in company application with an enum.
Previously, the virtual state depended on whether the
rejectedAt
andapprovedAt
fields were defined. Now it is defined with an explicit enum instead of being a virtual field.I also had to define a default function for the application state enum depending on those same fields. With a simple default
PENDING
, migrating the database would cause approved/rejected applications to be seen as pending. This function makes the default value depend onapprovedAt
andrejectedAt
.Also replaced the tests related with the virtual state.
Closes #312